Michael added a comment.
That `EventEmittingButton` component uses a link (`<a>`) with `href="#"` and styled as a button. This is an anti-pattern and poses accessibility issues <https://dequeuniversity.com/rules/axe/3.0/href-no-hash>. If we need a button, then let's use a semantically correct element and use links if we actually want to link to something. This will also make our component simpler. TASK DETAIL https://phabricator.wikimedia.org/T230326 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Michael, Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
