Ladsgroup added a comment.
In T207893#5429435 <https://phabricator.wikimedia.org/T207893#5429435>, @dbarratt wrote: > Oversight on my part, it looks like the creation code (in both patches) is using `AbstractBlock::isSitewide()` instead of `AbstractBlock::appliesToNamespace()` (as is outlined in the task description). Using the former means that someone who is blocked from a namespace **will** be allowed to create an item in that namespace, using the latter will ensure they are blocked properly from that namespace. I just want to mention those parts are for basic access to the special page, the real action is being handled by PermissionManager so nothing is broken here. TASK DETAIL https://phabricator.wikimedia.org/T207893 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Ladsgroup Cc: alaa_wmde, dom_walden, hoo, Ladsgroup, Tchanders, Niharika, Lydia_Pintscher, WMDE-leszek, TBolliger, Lucas_Werkmeister_WMDE, Addshore, Aklapper, dbarratt, MGChecker, darthmon_wmde, MattLongCT, DannyS712, Nandana, aezell, Lahi, Gq86, dmaza, GoranSMilovanovic, SPoore, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, PEarleyWMF, RuyP, jrbs, Jonas, Wong128hk, Bsadowski1, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
