Pablo-WMDE added a comment.
Agree with @Lucas_Werkmeister_WMDE in that the test could needs some love. The `ItemPage.editItemDescription()` is definitely still part of the arrange phase <http://wiki.c2.com/?ArrangeActAssert> so it could be done via the API just as well (=> second API call, chaing the label, creating a second revision), the revision id which is the result of the initial `WikibaseApi.createItem()` (=> make a sister method which does not reduce this to the itemId), is a what we actually want to know when doing `ItemPage.goToPreviousRevision()` - once we have them we could use it to open the item page with it (=> mend `ItemPage.open()`/`EntityPage.open()` to accept a revision parameter; probably requires mending `Special:EntityPage` to also pass forward the revision paramter). What this test tries is actually quite simple, it gets tricky because the existing methods (e.g. `WikibaseApi.createItem()`) are so helpful that they do away with key information (which arguably makes sense most of the time). TASK DETAIL https://phabricator.wikimedia.org/T232363 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, Pablo-WMDE Cc: Pablo-WMDE, Jakob_WMDE, Lucas_Werkmeister_WMDE, Aklapper, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, B20180, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
