Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Bridge. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION **Problem:** We noticed while reviewing I027550414d <https://gerrit.wikimedia.org/r/540388> that the resizing text field sometimes starts out much too high: F30524515: Screenshot from 2019-10-02 17-57-21.png <https://phabricator.wikimedia.org/F30524515> So far, we have only been able to reproduce this in the browser tests. It happens when two tests share the same item (created in a `before` hook); in the second test, the `Special:EntityData` request is cached, and the store can therefore initialize itself faster than usual (i. e., this seems to be a race condition), and when `ResizingTextField.resizeTextField()` is triggered by the `mounted` hook, it gets an incorrect width (14px – one character?), leading it to think that it needs to be much higher in order to fit the full text value. Wrapping different parts of the initialization in `setTimeout( …, 0 );` seems to be one way to resolve this, but more investigation would be good. **Example:** When I027550414d <https://gerrit.wikimedia.org/r/540388> is merged, `canCancel.js` is one group of tests that demonstrates this behavior; you can “sleep” before the `cancelButton.click` in the second test to keep the dialog alive for longer. **Acceptance criteria:** - The text field always has the correct height. TASK DETAIL https://phabricator.wikimedia.org/T234451 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
