alaa_wmde added a comment.
So trying to save the above example of long version, it ended up in database in comment table (comment_text column) as: `/* wbsetclaim-create:2||en, label, "Frame of Notre-Dame de Paris"|fr, alias, Marie|es, description, ""this is a loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong description"|en, description, "this is a much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much much looooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo...` 500 characters long. So I think that's our "hard" limit coming from mediawiki core level (since in DB we can really store much more than that). When looked in core why that's truncated, turns out CommentStore in core does truncate the comment https://github.com/wikimedia/mediawiki/blame/74b46a1f3364d5529d408c2e061dd98100b8ddbd/includes/CommentStore.php#L490 and the limit is hard set in the class (been reduced from 1000 to 500 ~2 years ago). https://github.com/wikimedia/mediawiki/blame/74b46a1f3364d5529d408c2e061dd98100b8ddbd/includes/CommentStore.php#L37 **What does that mean for us?** The bad and sad news first. I think we should not touch the hard limit of that truncation happening in CommentStore in order to avoid undesirable effects all over the place and expanding the scope of this story technically too much. The good news. We know what the limit in characters is exactly. It is a small limit, so we might actually hit it with our expanded version if few not-that-short descriptions were provided in one edit. - I will try to come up with something reasonable in terms of how to switch from one version to the other, based on this characters limit we have. TASK DETAIL https://phabricator.wikimedia.org/T224014 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Jakob_WMDE, Lea_WMDE, Aklapper, Lydia_Pintscher, Lucas_Werkmeister_WMDE, alaa_wmde, Iflorez, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
