matthiasmullie added a comment.
Update: while above patches got merged, Lua still won't work by next week's deployment (at least not until some more issues are straightened out, but they may require some more work) Beta (and the same should be true for production) doesn't seem to run the MediaInfo specific `PrefetchingTermLookup` alternative (that doesn't lookup in wb_terms) As far as I can tell up to now, it looks like this is because of `$wgWBClientSettings['useEntitySourceBasedFederation'] = true;` config, which, AFAICT, was a solution to deal with T211800 <https://phabricator.wikimedia.org/T211800>. `useEntitySourceBasedFederation` results in `MultipleEntitySourceServices` & `SingleEntitySourceServices` being used instead of `MultipleRepositoryAwareWikibaseServices`. It appears that `SingleEntitySourceServices` doesn’t use the service wiring files. Instead, most of what’s in the service wiring seems to be duplicated in that class. Unfortunately, that means the MediaInfo-specific `PrefetchingTermLookup` is never used, but the hardcoded original is (https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/data-access/src/SingleEntitySourceServices.php#L270) Investigating further... TASK DETAIL https://phabricator.wikimedia.org/T223792 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: matthiasmullie Cc: Tpt, LucasWerkmeister, jleedev, MarkTraceur, Yann, Addshore, Smalyshev, Mholloway, matthiasmullie, Multichill, Marsupium, Keegan, Jheald, Mike_Peel, Cparle, Aklapper, Jarekt, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Edtadros, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, JKSTNK, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Ramsey-WMF, Darkminds3113, Anooprao, SandraF_WMF, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tramullas, Acer, LawExplorer, Salgo60, WSH1906, Lewizho99, Maathavan, Silverfish, _jensen, rosalieper, Susannaanas, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
