Lucas_Werkmeister_WMDE added subscribers: abian, Lucas_Werkmeister_WMDE. Lucas_Werkmeister_WMDE added a comment.
The discussion in T231209 <https://phabricator.wikimedia.org/T231209> assumes that we do this via JS, by checking `mw.config.get( 'wgIsProbablyEditable' )`. But I think we can do this via CSS, depending on the `mw-editable` class on the surrounding body (added in T208315 <https://phabricator.wikimedia.org/T208315>) – that CSS could either be part of the init module, or be added PHP-side so it doesn’t even have to wait for ResourceLoader. I think this would be more efficient and better for the user (no flash of unhidden edit buttons before we get around to hiding them). In fact, it looks like this is exactly what `mw-editable` was added for? This code in eswiki:common.css <https://es.wikipedia.org/w/index.php?title=MediaWiki:Common.css&oldid=119959441> looks very similar to what we’d want: /* * Evitar que usuarios no confirmados se salten las semiprotecciones * a través de la edición en Wikidata: [[phab:T208315]], [[phab:T207648]]. */ .wikidata-link { display:none; } body.mw-editable .wikidata-link { display:inline; } Except that we identify Wikidata Bridge links differently. TASK DETAIL https://phabricator.wikimedia.org/T235152 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, abian, Aklapper, Lydia_Pintscher, darthmon_wmde, Michael, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
