Mvolz added a comment.
In T212069#5592396 <https://phabricator.wikimedia.org/T212069#5592396>, @Lucas_Werkmeister_WMDE wrote: > In T212069#4827851 <https://phabricator.wikimedia.org/T212069#4827851>, @Anomie wrote: > >> Relevant code for this specific example: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/6eea7f8d5e52a528877748391e3fae965f752018/repo/includes/Api/ResultBuilder.php#1019. Changing that `""` to `true` should do it, although with how complicated Wikibase's code is I can't say for sure. > > That would only change `"missing"` from `""` to `true`, I think, whereas the example in the task description also has `entities` change from an object to an array. This is analogous to the change of `query`’s `titles` in MediaWiki core (which the JSON v2 documentation <https://www.mediawiki.org/wiki/Special:PermanentLink/3390083#Changes_to_JSON_output_format> describes as specific to that API module). > However, that would be a //massive// breaking change to `wbgetentities`, even more so than changing `claims` to `statements`, which was previously discussed in T149410 <https://phabricator.wikimedia.org/T149410> – I can’t imagine any use of `wbgetentities` that would be unaffected by this. It //might// be something to consider for a hypothetical `formatversion=3` – though even then, I’m not convinced of its usefulness, since entity IDs are much less internal than `query/titles`’ page IDs, and once you have multiple entities in the response an array is arguably less useful than an object – but I don’t think we should make such a change for `formatversion=2`. My understanding /interpretation behind formatversion 2 is that it isn't expected to be stable (https://www.mediawiki.org/wiki/API:JSON_version_2) and that by default everyone gets formatversion 1 anyway. So this would be more bringing up the api up to spec for version 2, not adding breaking changes, because most people shouldn't be requesting the format version or requesting 2 if they want the format specified by default/1. I don't think there are any plans on doing a version 3 in particular. TASK DETAIL https://phabricator.wikimedia.org/T212069 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Mvolz Cc: Lucas_Werkmeister_WMDE, WMDE-leszek, alaa_wmde, Mvolz, Anomie, Aklapper, Yurik, darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, DannyS712, Nandana, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Sethakill, dg711, _jensen, rosalieper, Agabi10, Pchelolo, Wikidata-bugs, aude, jayvdb, Mbch331, Legoktm
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
