Mvolz added a comment.
In T233790#5586230 <https://phabricator.wikimedia.org/T233790#5586230>, @Ladsgroup wrote: > In T233790#5586170 <https://phabricator.wikimedia.org/T233790#5586170>, @Mvolz wrote: > >> We were already not using a global module, i.e. loading it using mw.loading elsewhere in the code, so it should not have affected the tree whatsoever. > > I think there's a misunderstanding here, by global, we tend to avoid using `wikibase.datamodel.*` variables which happens regardless of the way you load the module (as dependency declared or lazy loaded using `mw.loader`) > Can you explain the problem better to me? We just squeezed all modules to one module called `wikibase.datamodel` and you load it whatever way you want but use it with `require` (more info <https://www.mediawiki.org/wiki/ResourceLoader/Package_modules>) Whoops, you're right, sorry about that! TASK DETAIL https://phabricator.wikimedia.org/T233790 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE, Mvolz Cc: Mvolz, Ladsgroup, Aklapper, Jakob_WMDE, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
