Ladsgroup closed this task as "Declined". Ladsgroup added a comment.
The team decided to go with Package modules instead of webpack: https://www.mediawiki.org/wiki/ResourceLoader/Package_modules and reduced the number of modules that wikibase registers from 260 to 85. The reason we went with package modules was: - It's easier to migrate such a huge codebase to package modules - The tests are easier to adapt given the current paradigm of running qunit tests in RL and browser context. - If we change our mind later and switch to webpack, it would be still doable and easier than now given that both understand `require` - The rebase hell that would come with checking the dist file in VCS. We still went with webpack in the submodules that work independently of Wikibase (like WikibaseSerializationJavaScript <https://github.com/wmde/WikibaseSerializationJavaScript> and WikibaseDataModelJavaScript <https://github.com/wmde/WikibaseDataModelJavaScript>) to run the tests in the context of karma + webpack + node but at the same time RL understands those notations when the code is being pulled as a RL module in the wikibase extension (as a submodule). We are willing to revisit this decision if circumstances change, specially regarding tests and the build step. I personally would be very happy with using uglifyJS to make the bundle smaller (the current size is 1.8MB which is, to put mildly, crazy) TASK DETAIL https://phabricator.wikimedia.org/T228513 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: santhosh, Rosalie_WMDE, nray, Niedzielski, Jakob_WMDE, Aklapper, alaa_wmde, Addshore, Lydia_Pintscher, WMDE-leszek, Ladsgroup, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Vali.matei, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Volker_E, Wikidata-bugs, aude, GWicke, Dinoguy1000, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
