Mike_Peel added a comment.

  In T235811#5657800 <https://phabricator.wikimedia.org/T235811#5657800>, 
@egardner wrote:
  
  > The widgets in the WikibaseMediaInfo extension use templates and `render()` 
methods to ensure that the visible UI remains in sync with the structured data 
as it changes. Existing DOM elements are often thrown out and re-rendered from 
scratch to ensure consistency. Our introduction of this workflow into the 
Captions widget is probably what initially broke this gadget.
  
  This is not a good workflow - please reconsider it. It's better to minimize 
the Javascript as much as possible, and to keep a clean UI in HTML/CSS. 
Abruptly re-rendering things and throwing things out leads to unexpected 
behaviour for other developers, like we're seeing here.
  
  Also, please consider bringing this gadget in-house - it was developed 
because the community asked for it, and at least making the caption box 
collapsible by default would be a good step forward.

TASK DETAIL
  https://phabricator.wikimedia.org/T235811

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mike_Peel
Cc: egardner, Mike_Peel, Jdforrester-WMF, Abit, Masumrezarock100, zhuyifei1999, 
Jmabel, Aklapper, JKSTNK, Lahi, PDrouin-WMF, E1presidente, Ramsey-WMF, Cparle, 
Anooprao, SandraF_WMF, Tramullas, Acer, Salgo60, Silverfish, Poyekhali, 
Taiwania_Justo, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, 
Base, matthiasmullie, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, 
Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Keegan
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to