thiemowmde added a comment.
> […] we have to maintain list of units, globes, etc inside the code As suggested a while ago <https://phabricator.wikimedia.org/T167565#3359160>, I don't think it is necessary to make the code know what valid units, globes, etc. are. All I'm asking for is a basic check for `http://www.wikidata.org/entity/Q\d+`. In other words: If the URL points to the wikidata.org domain, make sure it not only uses the proper concept base URI (e.g. `http://www.wikidata.org/entity/` or whatever it is), but also make sure it addresses a valid Q-ID. The later is currently not done. All it currently does is a prefix check. See ValidatorBuilders.php <https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/repo/includes/ValidatorBuilders.php$438>. I'm not sure if any of the use cases (units, calendar models, …) currently allows to use **other** domains that are not wikidata.org. If this is the case, the validator should first check if the domain is wikidata.org, and only then apply the other checks explained above. TASK DETAIL https://phabricator.wikimedia.org/T167565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Addshore, Lea_Lacroix_WMDE, MisterSynergy, abian, Mbch331, matej_suchanek, Pasleim, PokestarFan, Lydia_Pintscher, Ladsgroup, thiemowmde, daniel, Aklapper, Smalyshev, darthmon_wmde, Dinadineke, DannyS712, Nandana, tabish.shaikh91, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, merbst, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, TheDJ
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
