Joe added a comment.
In T237319#5681384 <https://phabricator.wikimedia.org/T237319#5681384>, @darthmon_wmde wrote: > Is there anything that we can quickly do on wikibase to fix this? > if so, please advise what concretely. > Thanks! In general, whenever your code decides to respond with a 304 not modified or a 204 no content status code, no content body should be sent to the client. While the FCGI specification[1] isn't extremely clear on this topic, the HTTP one is, and for instance nginx refuses to accept as valid 304 responses with a body, see for instance https://trac.nginx.org/nginx/ticket/459 So the code for `Special:EntityData` should not emit a body when returning a 304 response code, or any wikibase installation using nginx as a webserver would fail to respond to `Special:EntityData`. [1] FCGI is the protocol PHP-FPM speaks - specification is here https://github.com/fast-cgi/spec/blob/master/spec.md (rather obscure, in fact) TASK DETAIL https://phabricator.wikimedia.org/T237319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Joe Cc: darthmon_wmde, elukey, Addshore, WMDE-leszek, Ladsgroup, CDanis, Joe, Vgutierrez, ema, Nikerabbit, DannyS712, Aklapper, Legado_Shulgin, Nandana, Davinaclare77, Qtn1293, Techguru.pc, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, faidon, Mbch331, Rxy, Jay8g, fgiunchedi
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
