daniel added a comment.
In T238878#5730630 <https://phabricator.wikimedia.org/T238878#5730630>, @Milimetric wrote: > In T238878#5708257 <https://phabricator.wikimedia.org/T238878#5708257>, @daniel wrote: > >> By the way, if you find rev_deleted != 0 for the current revision, it's a bug. The deletion flags for the current revisions will be ignored by the storage layer. > > I checked this as I was re-reading and there are 2500 such problems: Thanks for following up on this. I checked the code again, and I was (somewhat) wrong: the current revision can't have its //text// suppressed, but it can have the user and comment suppressed. The but map for DELETED_TEXT is 0x01, so the entry would be bad if rev_deleted is an odd number. I didn't spot any odd values when eyeballing the output you linked. Special:RevisionDelete prevents the DELETED_TEXT flag to be applied to the current revision. I didn't check whether that's safe against race conditions, and whether it can be circumvented with partial undeletion. But so far, there seems to be nothing bad in the database. I seem to recall that some code skips permission check for the current revision, but I can't find any such code right now to check whether it skips the check just for the text, or also for comments and user name. In any case, for the purpose of this task, rev_deleted can be ignored. TASK DETAIL https://phabricator.wikimedia.org/T238878 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Milimetric, Cparle, nettrom_WMF, Ladsgroup, daniel, Mayakp.wiki, gsingers, matthiasmullie, Addshore, kzimmerman, mpopov, Ramsey-WMF, Abit, Nuria, 4748kitoko, darthmon_wmde, DannyS712, Nandana, JKSTNK, Akovalyov, Lahi, PDrouin-WMF, Gq86, E1presidente, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, JAllemandou, Jane023, terrrydactyl, Wikidata-bugs, Base, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, jeremyb
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
