Tgr added a comment.
(See also T202763: Update extensions which customize content diff rendering <https://phabricator.wikimedia.org/T202763>.) DifferenceEngine calls the renderer of the right-hand item (so if you compare wikibase item to wikitext, it will call TextSlotDiffRenderer, if you compare wikitext to wikibase item, it will call EntityContentDiffView). That's not great, extensions should be able to provide wikitext diffing logic without having to override the wikitext diff renderer class. I'm not sure what would be the sane way to achieve that, though. If you compare A and B and the diff renderer for A throws an exception, catch and call the renderer for B? That feels very dirty; even if we replace exception catching with some kind of capability detection mechanism, it seems fragile. TASK DETAIL https://phabricator.wikimedia.org/T231084 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tgr Cc: Umherirrender, Ladsgroup, Tgr, Michael, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
