daniel added a subscriber: Anomie. daniel added a comment.
In T233520#5805312 <https://phabricator.wikimedia.org/T233520#5805312>, @Addshore wrote: > Adding core platform team to get some feedback and figure out: > > - When exactly this change in behaviour happened? > - I have looked through various gerrit changes and code paths but i'm sure someone that has worked on this code would be able to figure out exactly when this happened. > - It's slightly confusing as some stages look like a partial implementation, in some places, that may not have worked as expected etc. To be honest, I find this code rather confusing myself. Maybe @anomie or @aaron can help. > - Does it make sense currently that our property parser function is updated on the page, but the stuff in the ContentAlterParserOutput is not done? That seems wrong. If a new ParserOutput is generated and cached, ContentAlterParserOutput should run. Since it is triggered by Content::getParserOutput, I can't imagine how the PO would get into the ParserCache without this hook running. Maybe it does run, but doesn't do the deed? > - Is RevisionDataUpdates the right way to go for the page_props update? No. RevisionDataUpdates is the right place to pull things from ParserOutput and write it to the database. But for page_props, that's already done by the standard update. If the data is in ParserOutput (via setProperty), it should be recorded in the database. TASK DETAIL https://phabricator.wikimedia.org/T233520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, daniel Cc: Anomie, Petar.petkovic, Zoranzoki21, Tacsipacsi, matej_suchanek, Bencemac, Urbanecm, RolandUnger, alaa_wmde, Ladsgroup, Lea_Lacroix_WMDE, LibrErli, Krinkle, daniel, tstarling, aaron, WMDE-leszek, Addshore, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Jheald, Aklapper, Mike_Peel, darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, Agabi10, Taiwania_Justo, Scott_WUaS, Pchelolo, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Steinsplitter, Mbch331, Keegan
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
