Tarrow added a comment.
I was looking through this task. As far as I can tell to achieve what we need for the story we do not want to have the stopEditingHook set the TaintedState to false. Indeed, the story is about keeping a statement tainted after cancelling. I think we should actually only change the editingState on the stopEditing hook. I therefore suggest we change the task title from "Cancel hook handler should set taintState to false" to "StopEditing Hook should dispatch STOP_EDIT action" @hoo and @Rosalie_WMDE can you double check if I've made some mistake? TASK DETAIL https://phabricator.wikimedia.org/T242119 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo, Tarrow Cc: Tarrow, Lydia_Pintscher, Aklapper, Rosalie_WMDE, Sarai-WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
