Joe added a comment.
In T240884#5813174 <https://phabricator.wikimedia.org/T240884#5813174>, @Daimona wrote: > In T240884#5810160 <https://phabricator.wikimedia.org/T240884#5810160>, @sbassett wrote: > >> In T240884#5810094 <https://phabricator.wikimedia.org/T240884#5810094>, @Ladsgroup wrote: >> >>> One complicating factor here is that AbuseFilter and SpamBlacklist both don't have a clear maintainer. >> >> I think @Daimona is understood to be the de facto AF maintainer these days (trusted dev, wmf-NDA, etc.) and is pretty active <https://gerrit.wikimedia.org/r/q/project:mediawiki%252Fextensions%252FAbuseFilter> in its current development. > > So, I'm going to answer for myself. I think a re2-like solution would indeed improve performance [1] for regexps-related extensions. AbuseFilter and SpamBlacklist for sure, but also TitleBlacklist, and CentralAuth as of T101615 <https://phabricator.wikimedia.org/T101615>. Given the number of possible consumers, I believe that a reusable service would be the best choice. > Of note, there's also T187669 <https://phabricator.wikimedia.org/T187669> about adding a static ReDoS validator, in case you want to explore it as an alternative. > [1] - About AbuseFilter performance, some numbers are on grafana <https://grafana.wikimedia.org/d/000000393/mediawiki-abusefilter-profiling?orgId=1>, and there's also a dashboard <https://logstash.wikimedia.org/app/kibana#/dashboard/941a0560-b9b2-11e7-a3f7-cb9288bcae84?_g=h@1251ff0&_a=h@cf77ba6> on logstash, although regexps aren't the only responsible for slowness. Performace would be better if you interpret regexes locally with re2, so by using i.e. a php extension as @tstarling suggested. The advantage of a standalone service is that it works better if we need to use re2 from different services, so not just within MediaWiki. TASK DETAIL https://phabricator.wikimedia.org/T240884 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Joe Cc: Daimona, daniel, tstarling, Bawolff, Joe, WMDE-leszek, Volans, sbassett, Krinkle, Agabi10, Lucas_Werkmeister_WMDE, Addshore, Aklapper, Ladsgroup, darthmon_wmde, DannyS712, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, RazeSoldier, QZanden, LawExplorer, _jensen, rosalieper, D3r1ck01, Scott_WUaS, Izno, SBisson, Perhelion, Wikidata-bugs, Base, aude, GWicke, jayvdb, fbstj, santhosh, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, bd808, Legoktm
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
