Legoktm added a subscriber: Krinkle. Legoktm added a comment. In https://phabricator.wikimedia.org/T88436#1012436, @JanZerebecki wrote:
> But manually copying the dependencies of more than a dozen components > (Wikibase alone has more direct dependencies) and even recursively for their > dependencies does not seem a good way to improve this. Why would you need to do it recursively? Just include Wikibase's dependencies in vendor (still duplicated manually :() and let composer automatically figure out their dependencies. > The current build process is fully automated. So in the long run something > like https://github.com/wikimedia/composer-merge-plugin seems like a better > idea than manually doing this. But even then we would probably run composer > in the CI of individual extensions and only replace it by a build when > testing release branches, as otherwise we can't test changes to the > dependencies before making a building with that change. Or is there something > i'm missing that would allow us to not run composer? Right now extensions are tested with mediawiki/vendor loaded, so any dependency in there can be used when running tests. I had talked with @Krinkle yesterday about something related and he suggested having CI run composer install during normal commits, and wmf/* branch ones would use mediawiki/vendor. extensions/Wikidata/composer.json has the following dependencies: - wikibase/Wikidata.org (https://github.com/wmde/Wikidata.org) - an extension with no dependencies that could be moved to gerrit and deployed in the normal method - wikibase/wikimedia-badges (https://github.com/wmde/WikimediaBadges) - same - propertysuggester/property-suggester (https://github.com/Wikidata-lib/PropertySuggester) - same, though you would lose the composer autoloader - wikibase/wikibase (the "Wikibase" extension) - which has 19 dependencies So really only Wikibase has dependencies that need to be added to and managed with mediawiki/vendor. TASK DETAIL https://phabricator.wikimedia.org/T88436 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Legoktm Cc: Krinkle, aude, Legoktm, bd808, JanZerebecki, adrianheine, JeroenDeDauw, hashar, Aklapper, Wikidata-bugs _______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
