Lucas_Werkmeister_WMDE added a comment.
Notes from task breakdown:
- statements module has `StatementMap`, which is only updated after save and
always matches the revision ID in entity module
- root module has edit decision and string value
- on save, root module action clones statements module’s `StatementMap`,
applies the edit (either replace or update), and sends this to the API
- on success, update statements module’s `StatementMap` and entity module’s
revision ID
- on failure, not much to do – retry (compare T244356
<https://phabricator.wikimedia.org/T244356>) can do the same thing again
- the cloned `StatementMap` is ephemeral, not stored, probably just a
local-scope variable of the save action
- which does mean that the code to modify it (like the current
`setStringDataValue`) is not an action/mutation, it just updates a plain object
TASK DETAIL
https://phabricator.wikimedia.org/T238662
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Jakob_WMDE, Rosalie_WMDE, Charlie_WMDE, Michael,
Aklapper, Lydia_Pintscher, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS,
Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
