Krinkle added a comment.
@WMDE-leszek If I understand correctly, the issue is that an unsafe value is passed to `BagOStuff->get()`. Specifically, a value that has not gone through `makeKey()` on the same BagOStuff. A BagOStuff implementation may have any number of restrictions on its cache key format (such as forbidden characters, or maximum length). All of which makeKey() is responsible for normalising away. I don't think it's valid to assume that all supported language codes and variants are within a length and charset that all possible bagostuffs support. Although it seems likely that all such input be less than 20 chars and contain only ASCII, I don't think that's enforced. Especially for "uselang hack" cases such as `Special:Upload?uselang=de-somethingüberspecial`, which are currently supported by MediaWiki as long as they pass `Language::isValidCode` in RequetContext::getLanguage, which is quite tolerant. TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Krinkle Cc: Agusbou2015, Ladsgroup, hoo, Jakob_WMDE, Liuxinyu970226, Krinkle, Addshore, WMDE-leszek, Jdforrester-WMF, Aklapper, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
