Tarrow added a subscriber: Rosalie_WMDE. Tarrow added a comment.
So we (@Jakob_WMDE and @Rosalie_WMDE and me) looked at this in some detail. We came to the following conclusions (chip in if I misrepresented anything) The ideal solution is for us to fix \Wikibase\Lib\SimpleCacheWithBagOStuff to reduce the number of times it fails by including some attempt to use makeKey. We were not keen to touch this on a Friday to fix the UBN though because: - it's currently untested due to T237164 <https://phabricator.wikimedia.org/T237164> - it will change all our Wikibase caches (and potentially mean things like using new keys) We evaluated the patches by Leszek and concluded that: - it only filtered out possible non-term languages from the fallback chain - this meant that bad languages could still be passed on to the EntityAquirer We considered moving this test for a valid term language to the getLanguage method but the problem was still that: - this would mean that valid interface languages (but not valid terms languages) would be filtered out (e.g. users with interface language 'fil' would not fallback to 'tag' but straight to 'en'. I.e. we don't want to mix up user interface and term languages at this level. We concluded that code merged that resulted in these errors starting now is probably due to the usage of `\Wikibase\Lib\Store\TermCacheKeyBuilder::buildCacheKey`. The two "new" places that use this are `\Wikibase\Lib\Store\CachingPrefetchingTermLookup::getCacheKey` and `\Wikibase\Lib\Store\UncachedTermsPrefetcher::getCacheKey` whereas `\Wikibase\Lib\Store\CachingFallbackLabelDescriptionLookup::getTerm` has used this for some time. We are happy to see that these two are only concerned with terms so this seems an appropriate place to add that filtering. To quickly follow is: - back-portable patch to get the train going ASAP - separate patch for testing CachingPrefetchingTermLookup and UncachedTermsPrefetcher We will also make tickets/reevaluate priority for: - SimpleCacheWithBagOStuff being tested - Making SimpleCacheWithBagOStuff less likely to throw - investigating in greater detail how those bad languages got into wikibase scribunto (we struggled to see how in our rough and ready testing) TASK DETAIL https://phabricator.wikimedia.org/T245062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Rosalie_WMDE, Tarrow, Agusbou2015, Ladsgroup, hoo, Jakob_WMDE, Liuxinyu970226, Krinkle, Addshore, WMDE-leszek, Jdforrester-WMF, Aklapper, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Ricordisamoa, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list Wikidatafirstname.lastname@example.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs