Addshore added a comment.
So back when this lib was initially used it was needed to add to the require-dev of core it seems https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/446568/ (done as part of T199440 <https://phabricator.wikimedia.org/T199440>) It looks like that was removed in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/552166/ but not linked to this ticket. So to move forward this would have to be re added, pinned at the specific version too. And then this starts becoming messier, as outlined in T199440 <https://phabricator.wikimedia.org/T199440> this is not an ideal situation but apparently the only way we could make it work with the WMF CI. I'd propose we also restore this require-dev in the core composer.json for now pinned to the same version as in Wikibase, essentially restoring the way things were. In T237164#5893411 <https://phabricator.wikimedia.org/T237164#5893411>, @thiemowmde wrote: > It's not even used in an external context we don't know anything about but that it expects compatibility with PSR-16. No. This class is used in Wikibase. We know where it is used. My question is: Isn't it enough to have good coverage for all the code that is using this class? > "Coverage" is not about a number. Coverage is about the team having confidence the code they own does not break without a test protecting them. As far as I can see these tests exist. We want to conform to the PSR spec, hence the tests. If we didn't care about that detail, then we wouldn't be using the PSR instead and would just use bag o stuff directly. Some more details @ https://doc.wikimedia.org/Wikibase/master/php/adr_0001.html TASK DETAIL https://phabricator.wikimedia.org/T237164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Addshore Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
