Ladsgroup added a comment.

  In T233520#5895999 <https://phabricator.wikimedia.org/T233520#5895999>, 
@Addshore wrote:
  
  > Updating page touched would also work?
  >
  > In T233520#5855858 <https://phabricator.wikimedia.org/T233520#5855858>, 
@daniel wrote:
  >
  >> In T233520#5855751 <https://phabricator.wikimedia.org/T233520#5855751>, 
@Addshore wrote:
  >>
  >>> - updating page_touched would probably trigger a reparse of the page (and 
currently that doesn't happen for the case described)
  >>
  >> In practical terms, WikiPageUpdater should probably just call 
WikiPage::doPurge(), instead of trying to duplicate the functionality.
  >
  > This would update page touched via Title::invalidateCache as far as I can 
see.
  
  This already happens (changing page_touched) through `HTMLCacheUpdateJob` and 
that's one of the reasons the problem exists, because the 
try_to_get_cached_parser_output method (the aforementioned method I pasted) 
checks if the page_touched is newer than the rootTimeStamp which by definition 
is (root job is the change notification one that spawns HTMLCacheUpdateJob)

TASK DETAIL
  https://phabricator.wikimedia.org/T233520

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: CCicalese_WMF, Anomie, Petar.petkovic, Zoranzoki21, Tacsipacsi, 
matej_suchanek, Bencemac, Urbanecm, RolandUnger, alaa_wmde, Ladsgroup, 
Lea_Lacroix_WMDE, LibrErli, Krinkle, daniel, tstarling, aaron, WMDE-leszek, 
Addshore, Lydia_Pintscher, Lucas_Werkmeister_WMDE, Jheald, Aklapper, Mike_Peel, 
Iflorez, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Pchelolo, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, 
Dinoguy1000, Steinsplitter, Mbch331, Keegan
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to