Lucas_Werkmeister_WMDE added a comment.
I think when we created this task, we were thinking of using `wbsetclaim` or a similar API module, instead of `wbeditentity`. However, since we decided in T238662 <https://phabricator.wikimedia.org/T238662> that even “update” changes (new statement + demote existing statement) should happen in one edit, as far as I understand we’ll have to use `wbeditentity` at least for that case, as it’s the only API module that will let one edit more than one statement at once, I believe. So I think the only thing that we can do to send less data to the API is to drop the unmodified parts from the JSON we send to `wbeditentity`? As far as I understand, if we send something like `{ "claims": { "P123": [...] } }`, it won’t delete statements for other properties (or labels etc.), so this should be safe to do. (To remove a statement/label/etc. using `wbeditentity`, you explicitly have to mention it and include a `"delete"` key or similar, I believe.) I suppose we don’t even necessarily need any diffing for this – just remove everything except the statements for our target property? TASK DETAIL https://phabricator.wikimedia.org/T230343 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Charlie_WMDE, Matthias_Geisler_WMDE, Lucas_Werkmeister_WMDE, Aklapper, Pablo-WMDE, Sarai-WMDE, darthmon_wmde, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
