Jakob_WMDE added a subscriber: thiemowmde. Jakob_WMDE added a comment.
As discussed with @Lydia_Pintscher and @thiemowmde it should behave the following way: - if two users add a reference/qualifier at the same time (= edit with the same base revision), they should be merged, and both references/qualifiers get added - if two users edit the same reference/qualifier at the same time, it should get detected as a merge conflict **Technical Notes**: Edits made through the entity page UI via `wbsetclaim` do send a `baserevid` when making edits on statements. Looking into the `SetClaim` code I noticed that it currently deserializes the whole statement from the request <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/f650950f4bc41d15b921c8768bb587217203e68a/repo/includes/Api/SetClaim.php#191> and passes that into a `ChangeOpStatement` directly. I believe what it should instead be doing is to use a `ChangeOpDeserializer` to turn the requests into individual changes. Maybe that would already solve the problem. TASK DETAIL https://phabricator.wikimedia.org/T244430 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jakob_WMDE Cc: thiemowmde, Jakob_WMDE, Lydia_Pintscher, Addshore, Wikidata-bugs, Aklapper, Premeditated, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
