Lucas_Werkmeister_WMDE added a comment.
> Are the packages not rather dev dependencies and their goodness compiled into the components (dist)? Not as far as I can tell – `dist/wikibase-vuejs-components.common.js` doesn’t seem to contain their code, it loads them via `require()` (just like vue itself). I think the reason we don’t experience a lack of functionality in Bridge is that we //do// provide them – just using different versions: our `package.json` has `"vue-class-component": "^7.2.3"` and `"vue-property-decorator": "^8.4.0"`, each one major version above the `wikibase-vuejs-components` requirement. (I don’t know why the npm warning reports this as “none is installed” rather than “an incompatible version is installed” or something like that.) But since the `require()` call in the compiled dist file includes no version number, and the differences between the versions don’t seem to matter to us, it works out in practice. Proposed solution: make the component library declare peer dependencies on ^7|^8 and ^6|^7 versions. TASK DETAIL https://phabricator.wikimedia.org/T245837 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, Tonina_Zhelyazkova_WMDE, Lucas_Werkmeister_WMDE, Aklapper, Pablo-WMDE, Sarai-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
