Addshore created this task. Addshore added projects: Wikidata, Wikidata-Campsite, wikidata-tech-focus, Technical-Debt. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION A pattern emerged in the new term storage related db classes that maintains DB connections as class properties. This goes against current patterns, and means that a reference to the db connection may hang around for longer than expected and this may not be desirable. The pattern that should be used is: - Inject a loadbalancer - Get a connection from the load balancer when needed (repeated calls will end up getting the same connection) - Let the connection naturally fall out of scope at the end of your method A very crude code search for this pattern in wikibase is: https://codesearch.wmflabs.org/extensions/?q=%5C%24this-%3E.*%20%3D%20.*-%3EgetConnection&i=nope&files=&repos=Extension:Wikibase TASK DETAIL https://phabricator.wikimedia.org/T246468 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Aklapper, Tarrow, Addshore, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
