Charlie_WMDE added a comment.
In T239421#5932957 <https://phabricator.wikimedia.org/T239421#5932957>, @Lucas_Werkmeister_WMDE wrote: >> The string data value textfield should have a height of 40px (including border) and a font-size of 16px (https://gerrit.wikimedia.org/r/575567) > > @Charlie_WMDE a question that came up during review: does the height have to change as soon as the viewport size changes (e. g. when you resize the window), or is it mainly important that the size is correct when opening the bridge at a certain viewport size? With the current implementation, the height is only updated when the input value is changed. (It depends on the content – if the value doesn’t fit on one line, the input grows.) @Lucas_Werkmeister_WMDE to me, part of a responsive modal would be that the size changes when the viewport changes. TASK DETAIL https://phabricator.wikimedia.org/T239421 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, Charlie_WMDE Cc: Lydia_Pintscher, WMDE-leszek, darthmon_wmde, Pablo-WMDE, Michael, SaraiSan, Lucas_Werkmeister_WMDE, Sarai-WMDE, Aklapper, Charlie_WMDE, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
