Krinkle added a comment.
Evidence of T157651: sql.php runs LoadExtensionSchemaUpdates <https://phabricator.wikimedia.org/T157651> This is from the 23:00:00 UTC cron from puppet `cron/wikibase/dumpwikibaserdf.sh`, which calls `cron/wikibase/wikibasedumps-shared.sh`, which calls `sql.php` below to run an ad-hoc query. This is merely to show that the code path involving `Wikibase\…\DatabaseSchemaUpdater->doSchemaUpdate` was in fact called by `sql.php`. The fatal error itself (T238466 <https://phabricator.wikimedia.org/T238466>) below is harmless in this context. In fact, had the GlobalPreferences hook been even more broken it could've prevented the outage by failing the script before the "drop table" event. 2020-04-06T23:02:13 snapshot1008 /srv/mediawiki/multiversion/MWScript.php maintenance/sql.php --wiki wikidatawiki --json --query SELECT MAX(page_id) AS max_page_id FROM page Fatal error: Call to undefined method MediaWiki\Preferences\DefaultPreferencesFactory::setUser() #0 /srv/mediawiki/php-1.35.0-wmf.26/extensions/GlobalPreferences/includes/Hooks.php(43): GlobalPreferences\Hooks::getPreferencesFactory(User) #1 /srv/mediawiki/php-1.35.0-wmf.26/includes/Hooks.php(174): GlobalPreferences\Hooks::onUserLoadOptions(User, array) #2 /srv/mediawiki/php-1.35.0-wmf.26/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL) #3 /srv/mediawiki/php-1.35.0-wmf.26/includes/user/User.php(5135): Hooks::run(string, array) #4 /srv/mediawiki/php-1.35.0-wmf.26/includes/user/User.php(2889): User->loadOptions() #5 /srv/mediawiki/php-1.35.0-wmf.26/includes/parser/ParserOptions.php(1177): User->getOption(string) #6 /srv/mediawiki/php-1.35.0-wmf.26/includes/parser/ParserOptions.php(986): ParserOptions->initialiseFromUser(User, LanguageEn) #7 /srv/mediawiki/php-1.35.0-wmf.26/includes/parser/ParserOptions.php(1011): ParserOptions->__construct(User) #8 /srv/mediawiki/php-1.35.0-wmf.26/includes/Storage/DerivedPageDataUpdater.php(1433): ParserOptions::newFromUser(User) #9 /srv/mediawiki/php-1.35.0-wmf.26/includes/page/WikiPage.php(2068): MediaWiki\Storage\DerivedPageDataUpdater->doUpdates() #10 /srv/mediawiki/php-1.35.0-wmf.26/extensions/Wikibase/repo/includes/Store/Sql/SqlStore.php(336): WikiPage->doEditUpdates(MediaWiki\Revision\RevisionStoreRecord, User) #11 /srv/mediawiki/php-1.35.0-wmf.26/extensions/Wikibase/repo/includes/Store/Sql/DatabaseSchemaUpdater.php(89): Wikibase\Repo\Store\Sql\SqlStore->rebuild() #12 /srv/mediawiki/php-1.35.0-wmf.26/extensions/Wikibase/repo/includes/Store/Sql/DatabaseSchemaUpdater.php(61): Wikibase\Repo\Store\Sql\DatabaseSchemaUpdater->doSchemaUpdate(MysqlUpdater) #13 /srv/mediawiki/php-1.35.0-wmf.26/includes/Hooks.php(174): Wikibase\Repo\Store\Sql\DatabaseSchemaUpdater::onSchemaUpdate(MysqlUpdater) #14 /srv/mediawiki/php-1.35.0-wmf.26/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL) #15 /srv/mediawiki/php-1.35.0-wmf.26/includes/installer/DatabaseUpdater.php(129): Hooks::run(string, array) #16 /srv/mediawiki/php-1.35.0-wmf.26/includes/installer/DatabaseUpdater.php(195): DatabaseUpdater->__construct(Wikimedia\Rdbms\MaintainableDBConnRef, boolean, MwSql) #17 /srv/mediawiki/php-1.35.0-wmf.26/maintenance/sql.php(92): DatabaseUpdater::newForDB(Wikimedia\Rdbms\MaintainableDBConnRef, boolean, MwSql) #18 /srv/mediawiki/php-1.35.0-wmf.26/maintenance/doMaintenance.php(99): MwSql->execute() #19 /srv/mediawiki/php-1.35.0-wmf.26/maintenance/sql.php(230): require_once(string) #20 /srv/mediawiki/multiversion/MWScript.php(101): require_once(string) #21 {main} TASK DETAIL https://phabricator.wikimedia.org/T249565 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Krinkle Cc: Krinkle, NickK, Sakretsu, Urbanecm, MisterSynergy, Christian75, Fuzheado, Emaus, RexxS, Paladox, MaxSem, BRPever, AntiCompositeNumber, Coffeeandcrumbs, ppelberg, Catrope, Esanders, Jdforrester-WMF, MMiller_WMF, Jdlrobson, Piramidion, kolbert, Pigsonthewing, Wittylama, AntonierCH, PKM, Erutuon, Moebeus, Zoranzoki21, MusikAnimal, Thibaut120094, Pcoombe, RoySmith, Bugreporter, Addshore, Miraclepine, Ladsgroup, Can_I_Log_In, Krenair, Ahmad252, Dreamy_Jazz, Tgr, Koavf, DannyS712, Aklapper, Oblanco79, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, jijiki, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Imarlier, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Marostegui, LawExplorer, WSH1906, Lewizho99, Minhnv-2809, Maathavan, elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wong128hk, Wikidata-bugs, aude, Bawolff, ArielGlenn, Lydia_Pintscher, He7d3r, Mbch331, Rxy, Jay8g, akosiaris
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
