egardner added a comment.
The WikibaseMediaInfo extension attempts to determine the data type of every property that's referenced on a given file page. This is done in PHP so that we don't have to make a bunch of API requests in the user's browser. Trying to look up a deleted property causes things to blow up here. I put a quick patch together to handle this situation a little better. 1. If the server-side property type lookup fails (i.e. if a property is referenced in statements on a given file page, and later deleted) then set the type to "unsupported" 2. When the JS on the page first initializes, don't bother replacing server-generated statement panels that correspond to deleted properties with interactive JS widgets; this means the user will at least see some messages about a deleted property and any values that had been attached to it. The user will not be able to edit or delete this panel for the time being, but we can figure out the best way to allow for that in a follow-up. 3. At the qualifier level, show some kind of "unsupported property" message and don't allow users to edit the values that previously had been set. Currently, removing these qualifiers does not count as a valid "change" from the panel's perspective. But if the user makes other changes and clicks "publish", the qualifiers associated with the deleted property will be removed. This could be improved, obviously. Here are some screenshots of what the user would see in such a scenario. F31744685: Screen Shot 2020-04-08 at 3.26.13 PM.png <https://phabricator.wikimedia.org/F31744685> F31744720: Screen Shot 2020-04-08 at 3.26.24 PM.png <https://phabricator.wikimedia.org/F31744720> TASK DETAIL https://phabricator.wikimedia.org/T249688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: egardner Cc: egardner, Aklapper, nnikkhoui, Cparle, Bugreporter, Eric_Luth_WMSE, Alicia_Fagerving_WMSE, Oblanco79, Alter-paule, Beast1978, CBogen, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Tore_Danielsson_WMSE, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
