Pablo-WMDE added a comment.
> If the entity ID is null: ... I conceptually agree with the tree of options you drew but don't think we can responsibly implement the branch "If the entity ID is null > If we’re in a unit test" in production code (that's why i called the null check without a plan B naive). Looking at `wikibase.ui.entityViewInit`, I wonder if `wikibase.entityPage.entityLoaded` can really be called its //dependency// - it's a script which triggers a hook. Making the firing of the hook itself a second class citizen (depend on something else) is kind of a double conditional. I think the hook should be a first class citizen (should fire when ever it is possible, i.e. `FullEntityParserOutputGenerator`) and who ever fancies should react to it (or not) how ever they please. What do you think (conceptually)? TASK DETAIL https://phabricator.wikimedia.org/T250305 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Lucas_Werkmeister_WMDE, WMDE-leszek, Pablo-WMDE, Aklapper, Reedy, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
