Addshore moved this task from Blocked / Waiting / External to Needs Product 
Work on the Wikidata-Campsite board.
Addshore added a subscriber: Lydia_Pintscher.
Addshore added a comment.


  Looking a tiny bit deeper than I did in T250621#6070573 
<https://phabricator.wikimedia.org/T250621#6070573> the code path that is taken 
goes through:
  
  WikiPageEntityStore::updateWatchlist and then watches the page via 
WatchAction::doWatch
  WatchAction::doWatch has a permission check, which I imagine fails due to the 
oauth grants
  
        public static function doWatch(
                Title $title,
                User $user,
                $checkRights = User::CHECK_USER_RIGHTS,
                ?string $expiry = null
        ) {
                $permissionManager = 
MediaWikiServices::getInstance()->getPermissionManager();
                if ( $checkRights && !$permissionManager->userHasRight( $user, 
'editmywatchlist' ) ) {
                        return User::newFatalPermissionDeniedStatus( 
'editmywatchlist' );
                }
  
  Either:
  
  - The desired behaviour is that in this situation watches should work 
(question for @Lydia_Pintscher)
  - OR that oauth tools that expect to be able to watch when editing should 
have the grant.
  
  I suspect the answer is point 1, and that will need a fix in wikibase!

TASK DETAIL
  https://phabricator.wikimedia.org/T250621

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lydia_Pintscher, Mbch331, Addshore, Aklapper, Epidosis, darthmon_wmde, 
Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to