Lucas_Werkmeister_WMDE added a subscriber: Michael.
Lucas_Werkmeister_WMDE added a comment.


  The implementation for this might be interesting, I think. Currently, 
`ErrorWrapper` has a lot of getters in its own class, for processing the list 
of errors from the store: `permissionErrors`, `unsupportedDatatypeError`, etc. 
The straightforward approach (to me) would be to add something similar for 
`saveErrors`, and mount the `ErrorSaving` if that list is not empty.
  
  But it looks like we’ll also need some similar logic in the store itself, for 
the store getter that indicates whether the “back” button should be shown or 
not (T249718 <https://phabricator.wikimedia.org/T249718>). So maybe some of 
this logic to filter the errors should move from `ErrorWrapper` into the store 
itself? What do you think, @Michael?

TASK DETAIL
  https://phabricator.wikimedia.org/T249717

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Aklapper, Lucas_Werkmeister_WMDE, Sarai-WMDE, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to