Krinkle added a comment.
--- a/includes/api/ApiResult.php
+++ b/includes/api/ApiResult.php
@@ -396,9 +396,15 @@ class ApiResult implements ApiSerializable {
if ( !( $flags & self::NO_SIZE_CHECK ) ) {
// self::size needs the validated value. Then flag
// to not re-validate later.
+ $start = microtime( true );
$value = self::validateValue( $value );
+ $duration = microtime( true ) - $start;
$flags |= self::NO_VALIDATE;
+ if ( @$_GET['krinkle'] ) {
+ wfDebugLog( 'AdHocDebug', 'Spent ' . round( $duration *
1000, 3 ) . ' ms in ' . __METHOD__ );
+ }
Two runs:
- Run 1
- Total time in PHP: 97 ms
- Time in ApiResult::validateValue (from ApiResult::addValue): ~ 4.8ms (5
top-level calls)
- Run 1
- Total time in PHP: 94 ms
- Time in ApiResult::validateValue (from ApiResult::addValue): ~ 3.7ms (5
top-level calls)
name=Raw data
krinkle@mw1378:/srv/mediawiki/php-1.35.0-wmf.31/includes/api$ curl
'http://mw1378.eqiad.wmnet/w/api.php?action=wbgetentities&ids=Q12184|Q17076801&props=info|aliases|labels|descriptions|claims|sitelinks|datatype&format=json&krinkle=1'
-i -H 'Host: www.wikidata.org' | grep Backend-Timing
Backend-Timing: D=97086 t=1588895607974196
timestamp: 2020-05-07T23:53:28+00:00
reqId: XrSfdwpAMNwAA5U6DdIAAABU
- Spent 3.655 ms in ApiResult::addValue
- Spent 0.002 ms in ApiResult::addValue
- Spent 1.088 ms in ApiResult::addValue
- Spent 0.001 ms in ApiResult::addValue
- Spent 0.001 ms in ApiResult::addValue
krinkle@mw1378:/srv/mediawiki/php-1.35.0-wmf.31/includes/api$ curl
'http://mw1378.eqiad.wmnet/w/api.php?action=wbgetentities&ids=Q12184|Q17076801&props=info|aliases|labels|descriptions|claims|sitelinks|datatype&format=json&krinkle=1'
-i -H 'Host: www.wikidata.org' | grep Backend-Timing
Backend-Timing: D=93593 t=1588895609066951
timestamp: 2020-05-07T23:53:29+00:00
reqId: XrSfeQpAMNwAA5U6Df4AAABX
- Spent 3.598 ms in ApiResult::addValue
- Spent 0.002 ms in ApiResult::addValue
- Spent 1.028 ms in ApiResult::addValue
- Spent 0.001 ms in ApiResult::addValue
- Spent 0.001 ms in ApiResult::addValue
TASK DETAIL
https://phabricator.wikimedia.org/T249587
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Krinkle
Cc: Krinkle, WMDE-leszek, Ladsgroup, Lea_Lacroix_WMDE, Addshore, Ixocactus,
Tarrow, Magnus, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS,
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
