sbassett added a comment.
Hey @darthmon_wmde- In T249039#6125290 <https://phabricator.wikimedia.org/T249039#6125290>, @darthmon_wmde wrote: > We have not frozen the code yet, are finishing the last 2.5 stories. Excuse my ignorance but, do we need to be 100% finished before the security review can happen? Although it has not been officially been documented within our Security Readiness Review SOP <https://www.mediawiki.org/wiki/Security/SOP/Security_Readiness_Reviews>, we typically ask code owners to select a "stopping point" for a review. This is ideally (a) commit sha(s) where the code is as close to production-ready as it can be so that we do not have to review a volatile codebase which may change substantially within a few days. Our team simply does not have the resources and sanity to conduct numerous reviews of volatile code. We understand this may not be possible in certain situations and that small changes (i18n, doc, etc.) can occur with little overall impact, but we strive to have the code in a stable, finished state prior to our reviews. So if there is more work to be completed (which seems to be the case with your mention of outstanding stories), we should likely wait until that work is completed before agreeing upon commit sha(s) for the review. > Other than that, please find here the documentation for the RegExp: https://www.mediawiki.org/wiki/Wikidata_Bridge/Development/DocDrafts/How_to_Enable_Wikidata_Bridge_for_your_Infobox Thanks. > I sent you a google doc today with the documentation on how to reproduce the DataBridge locally. Please, do no hesitate to ask if needed. Thanks, I'll review that and let you know. TASK DETAIL https://phabricator.wikimedia.org/T249039 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: sbassett Cc: WMDE-leszek, sbassett, Addshore, Michael, Lucas_Werkmeister_WMDE, Tonina_Zhelyazkova_WMDE, Pablo-WMDE, Lydia_Pintscher, Aklapper, darthmon_wmde, Sarai-WMDE, Dsharpe, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Bawolff, Mbch331, Legoktm
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
