Daimona added a comment.
In T250338#6170464 <https://phabricator.wikimedia.org/T250338#6170464>, @DannyS712 wrote: > @Daimona or another phan expert - would you be willing to take a look at the wikibase phan failure? It's coming from an array property, so likely a false positive. Upgrading taint-check might help, perhaps it's worth trying. I didn't investigate the failure locally, nor will I do that unless it still exists on master. Debugging taint-check failures is usually a process of trial and error that takes a lot of time. > The failure doesn't exist on master, and shouldn't have been caused by the commit, which doesn't touch any of the files involved in the phan error It doesn't matter. Taint-check scans the code base very deeply and is often nondeterministic. The patch above may well have caused this new issue to appear. TASK DETAIL https://phabricator.wikimedia.org/T250338 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, Daimona Cc: Daimona, Aklapper, Pchelolo, DannyS712, Naike, Blissjay007, Oblanco79, Alter-paule, NavinRizwi, Beast1978, Un1tY, eprodromou, Dzaky17, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, 94rain, CucyNoiD, Nandana, NebulousIris, kostajh, Gaboe420, Jony, lucamauri, Versusxo, Majesticalreaper22, Amorymeltzer, Giuliamocci, Adrian1985, Force_Radical, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Vexations, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, XanonymusX, Taiwania_Justo, Scott_WUaS, Cirdan, Izno, Zache, Wikidata-bugs, aude, Dinoguy1000, jeblad, brion, TheDJ, Jdforrester-WMF, Jackmcbarn, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs