Addshore moved this task from To Do to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board. Addshore added a comment.
So, Commons needs to be able to create an `ItemHandler` object in order to be able to do things with Items. An ItemHandler currently needs a `ItemTermStoreWriter`, as `ContentHandler` is also what does writes and secondary data updates in `getSecondaryDataUpdates` The patch above introduced a check making sure that these writers would only be created when the local entity source / local wiki has access to Items for writing, hence the exception. We could do one of the following: - Keep the check in the same place and instead inject the TermStoreWriterFactory into ItemHandler (or pass in a callback rather than an instantiated service) - Move the check out of TermStoreWriterFactory and into ItemTermStoreWriter? (feel ugly and this is what we just moved away from, why should the service be concerned with this?) Will continue on this in the morning TASK DETAIL https://phabricator.wikimedia.org/T253804 WORKBOARD https://phabricator.wikimedia.org/project/board/3539/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Cparle, Tarrow, darthmon_wmde, WMDE-leszek, Agusbou2015, Liuxinyu970226, Aklapper, mmodell, CBogen, Iflorez, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
