Krinkle reopened this task as "Open".
Krinkle added a project: Performance-Team (Radar).
Krinkle added a comment.


  In T254151#6188612 <https://phabricator.wikimedia.org/T254151#6188612>, 
@gerritbot wrote:
  
  > Change 601337 **merged** by jenkins-bot:
  > [mediawiki/extensions/WikibaseMediaInfo@master] Move wbTermsLanguages from 
config to package module
  >
  > https://gerrit.wikimedia.org/r/601337
  
  I was happy to read this, but no longer when I realised it actually creates a 
new module just for this data key. See Guidelines 
<https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader>).
 Move this to an existing module instead, which is where the power of package 
files truly comes through, as it allows virtual files to be added to any module.
  
  The WikibaseMediaInfo extension is currently excessive at having 13 distinct 
module bundle entrypoints (stats 
<https://grafana.wikimedia.org/d/BvWJlaDWk/startup-manifest-size?orgId=1&var-wiki=commonswiki&var-component=All&var-multiwiki=commonswiki&var-multiwiki=dewiki&var-multiwiki=enwiki>).
 This should be reduced further, not increased.
  
  From a quick glance, it seems the two modules that depend on this have lots 
of modules in common. Could it be added to one of those?

TASK DETAIL
  https://phabricator.wikimedia.org/T254151

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LucasWerkmeister, Krinkle
Cc: Krinkle, Aklapper, LucasWerkmeister, CBogen, darthmon_wmde, Nandana, 
JKSTNK, Jony, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, 
Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, 
LawExplorer, Vali.matei, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, 
Susannaanas, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, 
Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to