Niedzielski added a comment.
My recollection is that we added this script to the bottom because it would be guaranteed to arrive and be parsed last, as well as be non-render-blocking. I think the hook lifecycle also executed at a favorable time. I'm not sure if the same is true for this change. That's not to suggest any opinion, only that you may wish to verify if you haven't already. As you noted, the new placement appears well within guidelines. I'll add that we A/B tested the original implementation for months and this may have positive, negative, or no effect. There are related schema changes you may wish to weigh in on in T250317 <https://phabricator.wikimedia.org/T250317>. TASK DETAIL https://phabricator.wikimedia.org/T254631 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Niedzielski Cc: Niedzielski, Aklapper, dbarratt, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Chicocvenancio, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Krenair
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
