Addshore added a comment.
Had a quick call with @Jakob_WMDE to iron out the last few apparent issues, and we should have a patch together but the end of the day. T205268: Many services in GenericServices are not actually that generic. <https://phabricator.wikimedia.org/T205268> has it's hand in this issue. On commons as link such as `[[M123]]` is a valid link to a media info entity, so it goes through this hook rendering stuff. However, a namespace check occurs, which is grabbed from `GenericServices` where NS0 is registered as the namespace for item entities (all be it on a different repo) Hence we reach our error case. T205268 <https://phabricator.wikimedia.org/T205268> should be tackled to remove any of these services that are not actually generic. The other case that was missed and will be patched is interwiki prefixes in links, that were not tested or accounted for. Staring at this code further raises the question, do we want to allow links such as `[[Q123]] [[P123]] [[M123]]` in wikitext on commons? This is probably not something that was originally specified very well in #structureddataoncommons <https://phabricator.wikimedia.org/tag/structureddataoncommons/> and should be decided upon. TASK DETAIL https://phabricator.wikimedia.org/T255078 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: thcipriani, WMDE-leszek, Pablo-WMDE, tstarling, Samuele2002, Agusbou2015, Liuxinyu970226, toan, hoo, Rosalie_WMDE, Jakob_WMDE, Silvan_WMDE, Addshore, Tacsipacsi, Aklapper, Blissjay007, Jimfhahn, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Adidsone1, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Phukettaxigroup, lucamauri, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
