Jdlrobson created this task. Jdlrobson added projects: MediaWiki-Core-Skin-Architecture, MediaWiki-Interface, VisualEditor, MediaWiki-extensions-Translate, PictureGame, QuizGame, MediaWiki-extensions-CentralNotice, BlueSpice, MediaWiki-extensions-LinkedWiki, MediaWiki-extensions-PdfBook, MediaWiki-extensions-AdvancedMeta, MediaWiki-extensions-Approved-Revs, MediaWiki-extensions-Cargo, MediaWiki-extensions-CollaborationKit, Shape Expressions, FileAnnotations, Move-Files-To-Commons, MediaWiki-extensions-FlaggedRevs, StructuredDiscussions, Jade, MediaWiki-extensions-LiquidThreads, MassMessage, MediaWiki-extensions-MintyDocs, MediaWiki-extensions-Newsletter, MediaWiki-extensions-NSFileRepo, MediaWiki-extensions-Page_Forms, MediaWiki-extensions-PageSchemas, ProofreadPage, MediaWiki-extensions-Push, TimedMediaHandler, MediaWiki-extensions-TinyMCE, WikiLove, Vector. Restricted Application added projects: Social-Tools, Growth-Team, Wikidata.
TASK DESCRIPTION NOTE: low priority. Just wanted to capture this somewhere and start the conversation given the many extensions that use these. Every time the SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks are run we also run the SkinTemplateNavigation::Universal hook. The latter is always run based on the current page. We could just run the latter and get rid of 2 needless hooks. Proposal: ========= Having 3 hooks doing pretty much the same thing seems gratutious. I would suggest standardizing on **SkinTemplateNavigation::Universal ** and for the hooks themselves to do the required checks they need. I am however open to keeping all three after hearing from the current extensions using these hooks (tagged) and benefits they see in having three of them. The SkinTemplateNavigation hook is deprecated in favor of SkinTemplateNavigation::Universal . It's up to callers to check whether the title exists if they care. The SkinTemplateNavigation::SpecialPage is deprecated in favor of SkinTemplateNavigation::Universal. Callers must use $skin->getTitle() to check whether the page is a special page TASK DETAIL https://phabricator.wikimedia.org/T255319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson Cc: Aklapper, Krinkle, Ammarpad, Jdlrobson, Llanddewi, NavinRizwi, Shliilh65, keithbrianpadilla, Demian, Dzaky17, dlo, darthmon_wmde, Tombolano, Saimongoltinio, WikimeSteve, abi_, pdehaye, ppelberg, BryghtShadow, Kfield, 94rain, DannyS712, Nandana, Lens0021, JamesDriscoll, Schtom, ElanHR, marcella, Tumzaaaa24, kostajh, Revansx, aoxomoxoa, Jony, Pwirth, Mmiller0712, OhKayeSierra, Bhaskargoyal24, priyanshu_varshney, Amorymeltzer, AbhinavKhare, Nikhil-nk, lakshay234, 2angelic1, Apoorv07, AkinkuotuFunmi, takidelfin, Lahi, Himanshuc3, Gq86, Xinbenlv, Necroarcano, SapphieWillie, Devi59, Robinma, Xover, Andrawaag, GoranSMilovanovic, Fz-29, Kamsuri5, The-Gradient, 45Jayjay1969, Chicocvenancio, Nakohdo, Jonathan3, QZanden, Xephyr826, YULdigitalpreservation, Nicolas_NALLET, EnricoCNC, merbst, LawExplorer, spatton, EHCliffe, Snowwh1th3, Salgo60, JJMC89, Wess, Kc5vcx, Tshrinivasan, SteffenFelix, _jensen, Jseddon, rosalieper, Mkdw, XanonymusX, Taiwania_Justo, shinjiman, gabriel-wmde, Scott_WUaS, Karima, Srdjan_m, Cirdan, Info-farmer, c.holtermann, RHeigl, Samwilson, DStrine, SBisson, Lmorillas, Vedmaka, MisterSynergy, RichardHeigl, Oetterer, Aschroet, Jrf, Husun1297, abian, Zache, Wikidata-bugs, WMDE-Fisch, Yaron_Koren, Base, Tinaj1234, aude, Candalua, AndyRussG, Pcoombe, Jongfeli, Bawolff, QuimGil, Dinoguy1000, Gryllida, jeblad, Harej, brion, Swainr, fbstj, Prtksxna, Catrope, Lydia_Pintscher, 01tonythomas, Tpt, Nikerabbit, KartikMistry, Isarra, He7d3r, TheDJ, Jackmcbarn, Mbch331, Jay8g, ashley, Legoktm
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
