Addshore added a comment.
- `CachingEntityRevisionLookup::getEntityRevision` has the entity id and rev
id to lookup and tried to get it from the cache
- Failing, it calls `fetchEntityRevision`
- This ultimately calls `WikiPageEntityRevisionLookup::getEntityRevision`
- This then calls a method on `entityMetaDataAccessor`, either
`loadRevisionInformationByRevisionId` or `loadRevisionInformation`
Looking into the meta data accessor I see a note:
* @todo This whole interface may no longer be needed with the introduction
of RevisionRecord which can
* represent a revision on any wiki.
* MetaData accessing can probably be killed and instead RevisionRecord just
be returned.
- `loadEntity` is the called
- `revisionStore->getRevisionById` is called, returning out `RevisionRecord`
- We then also call `loadEntityDataFromWikiPageRevision` ? which comes with
the note:
// NOTE: Support for cross-wiki content access in RevisionStore
is incomplete when,
// reading from the pre-MCR database schema, see T201194.
// For that reason, we have to load and decode the content blob
directly,
// instead of using RevisionRecord::getContent() or
SlotRecord::getContent().
// TODO Once we can rely on the new MCR enabled DB schema, use
getContent() directly!
This method then calls `blobStore->getBlob` which is where the new layer of
shared caching lives.
TASK DETAIL
https://phabricator.wikimedia.org/T255305
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: Addshore, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86,
Pablo-WMDE, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
