Lucas_Werkmeister_WMDE added a comment.
I looked into this a bit. I can reproduce the error (by putting an `echo` or similar in `StorageLexemeSerializer` where the exception is thrown) when AbuseFilter is also installed. The execution happens roughly like this: - the WikibaseLexeme test asks the Wikibase API to save an incomplete Lexeme - the Wikibase API creates the `Content` and runs the EditFilterMergedContent hook - AbuseFilter gets the text of that `Content` - WikibaseLexeme throws an error when trying to serialize the incomplete Lexeme (language and/or lexical category missing) - (fuzzy) - the API returns an error - the WikibaseLexeme test asserts that the error looks as expected The exception thrown by `StorageLexemeSerializer` is caught and logged in Wikibase’s `EntityContentDataCodec::encodeEntity()`, but I haven’t yet been able to figure out what’s //supposed// to happen instead – since it seems that at some point, this test was able to complete without emitting anything to `mw-error.log`. That said, the above change seems to fix the issue by completely disabling the “exception” log channel – in the artifacts for that build <https://integration.wikimedia.org/ci/blue/organizations/jenkins/quibble-vendor-mysql-php72-noselenium-docker/detail/quibble-vendor-mysql-php72-noselenium-docker/17619/artifacts/>, I no longer see an `mw-error.log` file. This might not be the best solution (after all, Wikibase also has tests for EditEntity behavior with bad lexemes, and those tests don’t seem to disable any log channel), but it should be good enough to unblock the parent task, and better than disabling the tests. TASK DETAIL https://phabricator.wikimedia.org/T249838 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Krinkle, Addshore, Tarrow, WMDE-leszek, Pablo-WMDE, Aklapper, Lucas_Werkmeister_WMDE, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
