Addshore added a comment.
In T253624#6165716 <https://phabricator.wikimedia.org/T253624#6165716>, @Ladsgroup wrote: > In T253624#6165674 <https://phabricator.wikimedia.org/T253624#6165674>, @Krinkle wrote: > >> Note that `phpcs` ruleset is controllable per repository. The same way that we disable some rules in repositories not yet ready to follow a newer convention, it is also possible to enable additional rules on a per-repo bases. > > I think the reason back then was that wikibase team maintains lots of repos instead of one or two (which is another can of worms) and if we want to, for example, enforce a different rule for our codebase, we have to change all phpcs files one by one. I think we could solve that with a package anyway (having it use a hook to write a file into the correct place). But having these rules that synced I believe is undesired. TASK DETAIL https://phabricator.wikimedia.org/T253624 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Krinkle, Ladsgroup, Addshore, Aklapper, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, thiemowmde, Mbch331, Jay8g, Legoktm
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
