Lucas_Werkmeister_WMDE claimed this task. Lucas_Werkmeister_WMDE edited projects, added Wikibase Extension Decoupling and Registration (Sprint 1); removed Wikibase Extension Decoupling and Registration. Lucas_Werkmeister_WMDE added a comment.
In T255110#6224767 <https://phabricator.wikimedia.org/T255110#6224767>, I outlined three ways to achieve this; I’ll summarize them here: 1. Introduce an `EntityIdHolder` interface (somewhere outside Repo), make `EntityContent` implement it, and make `EntityChange` refer only to that interface rather than `EntityContent`. 2. Split `EntityChange` into two parts: the ones that are expected to be called from Repo and populate the change, and the ones that are expected to be called from Client and consume it. 3. Add an `EntityId` parameter to `EntityChange::setRevisionInfo()` and make the //callers// get the entity ID from the content (the callers are in Repo). I still like the concept behind #2, but #3 is so easy to implement that I couldn’t resist it. Patch incoming. TASK DETAIL https://phabricator.wikimedia.org/T255883 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
