Lucas_Werkmeister_WMDE added a comment.
I looked a bit into LuaWikibaseIntegrationTest and I’m also unsure what to do with that. The test saves an example item to `WikibaseRepo`’s entity store, creates a test module, and then tests the result of parsing various bits of wikitext that invoke that module. We could try to remove the dependency on `WikibaseRepo` by instead overriding `WikibaseClient`’s services (entity lookup etc.) to return the example item. But then the test becomes pretty similar to other tests, which already install a `MockClientStore`, and ultimately it’s not really an integration test anymore: it doesn’t test the full connection between Wikibase Repo and Client. If we say that this is a test which needs the WikibaseRepo extension to be installed, and that’s fine, but we want to avoid the direct coupling to the `WikibaseRepo` PHP class, then there are other ways to avoid that. We could, for example, save the example item using an API call. Come to think of it, we could also use API calls to create the test module, and to do the various test parses… maybe we can turn this test into a MediaWiki API integration test <https://www.mediawiki.org/wiki/MediaWiki_API_integration_tests>? TASK DETAIL https://phabricator.wikimedia.org/T255885 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Ladsgroup, Aklapper, Lucas_Werkmeister_WMDE, Hazizibinmahdi, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
