Ladsgroup moved this task from Verification to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 3) board. Ladsgroup added a comment.
The above patch is the last thing I can do to make it decoupled without weird gymnastics, there are five more that I don't know if there's a way to decouple them properly: - `mw.config.values.wbSiteDetails`: Build using php code living in lib, heavily used in both client and repo: https://codesearch.wmflabs.org/search/?q=wbSiteDetails&i=nope&files=&repos= - We might split the php file into two and copy them? - `mw.config.values.wbRepo`: Same, heavily used everywhere. - `wikibase` basic nonsense code that defines wikibase global object which is used everywhere. - `wikibase.api.RepoApi`: both client and repo depend on it and the obvious solution is to copy-paste it in both places but all of the code lives in a git submodule. - Have two identical submodule? - Don't give a damn and define it twice while both pointing to the same file, how is it different from status quo? - `wikibase.Site` defined dynamically through a hook in lib. Fun. - Copy the hook handler and the code? TASK DETAIL https://phabricator.wikimedia.org/T256054 WORKBOARD https://phabricator.wikimedia.org/project/board/4875/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
