Ladsgroup added a comment.
Also I found some more dead code (by removing dead code, you uncover more). Deleting them is not easy for a stupid reason: Their tests are convoluted so for example I can't drop getDataValues because the test for hasDataValues uses it... amsa@amsa-Latitude-7480:~/workspace$ python unused_js_functions.py ~/Wikibase /home/amsa/Wikibase/view/lib/wikibase-data-values/src/dataValues.js getDataValues /home/amsa/Wikibase/view/lib/wikibase-data-values/src/dataValues.js hasDataValue /home/amsa/Wikibase/view/lib/wikibase-data-model/src/Fingerprint.js hasLabel /home/amsa/Wikibase/view/lib/wikibase-data-model/src/Fingerprint.js hasDescription /home/amsa/Wikibase/view/lib/wikibase-data-model/src/Fingerprint.js hasAliases TASK DETAIL https://phabricator.wikimedia.org/T256054 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: WMDE-leszek, Ladsgroup, Tarrow, Lucas_Werkmeister_WMDE, Aklapper, ItamarWMDE, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs