Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Verification to Done on the
Wikibase Extension Decoupling and Registration (Sprint 3) board.
Lucas_Werkmeister_WMDE added a comment.
The change works, in that matching substrings are still marked as highlights
in the HTML:
<li class="ui-ooMenu-item" dir="auto"><a tabindex="-1"><span
class="highlight">En</span>glish (<span
class="highlight">en</span>wiki)</a></li>
That said, Wikibase does not define any special styles for the `highlight`
class, and hasn’t done so for quite some time, so the highlighting isn’t
visible by default. (In fact I couldn’t find any trace of the class //ever//
being styled in the Git history, but I’m sure it used to be in some submodule
or library that I missed. T68433 <https://phabricator.wikimedia.org/T68433> is
an old task for it.) On Wikidata, exactly two users style the class in their
common.css (search
<https://www.wikidata.org/w/index.php?search=insource%3A%2F\.highlight%2F+intitle%3Acss&ns2=1&ns8=1>):
User:Kiailandi <https://www.wikidata.org/wiki/User:Kiailandi/common.css> and
User:Hjfocs <https://www.wikidata.org/wiki/User:Hjfocs/common.css>. I hope
they’re happy that we’re still keeping this feature working ^^
TASK DETAIL
https://phabricator.wikimedia.org/T257475
WORKBOARD
https://phabricator.wikimedia.org/project/board/4875/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Tarrow, WMDE-leszek,
Ladsgroup, Hazizibinmahdi, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86,
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS,
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
